Update test for trailing comments when preserving comment formatting#259
Closed
Arvind Thirunarayanan (arvindth) wants to merge 1 commit into
Closed
Conversation
Arvind Thirunarayanan (arvindth)
requested a review
from a team
as a code owner
Arvind Thirunarayanan (arvindth)
force-pushed
the
ath-SEC-283-trailingCommentTest
branch
from
d87159e to
8427904
Compare
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
========================================
Coverage ? 40.7%
========================================
Files ? 61
Lines ? 4678
Branches ? 0
========================================
Hits ? 1904
Misses ? 2530
Partials ? 244Continue to review full report at Codecov.
|
Member
Author
|
Wasn't passing due to fork permissions. Duplicated with PR #260. |
Arvind Thirunarayanan (arvindth)
deleted the
ath-SEC-283-trailingCommentTest
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functionality is now provided by the underlying library without the need for a dummy trailing key-value pair. So the location of the trailing comment now remains at the end of the properties.
Fixes a test failure in #252